Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all ray-query flags in constants #5429

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

kvark
Copy link
Member

@kvark kvark commented Mar 23, 2024

Connections
Port of gfx-rs/naga#2375

Description
We are making the ray query flags a part of the API here.
Also bringing the basics of candidate intersections.

Testing
Not really tested.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@kvark kvark requested a review from a team March 23, 2024 19:32
@kvark kvark changed the title Expose all ray-query flags in constantsRt constants Expose all ray-query flags in constants Mar 23, 2024
naga/src/lib.rs Outdated Show resolved Hide resolved
@cwfitzgerald
Copy link
Member

Boop from triage

@kvark kvark requested a review from a team as a code owner November 23, 2024 09:19
@kvark
Copy link
Member Author

kvark commented Nov 23, 2024

PR has seen a substantial revamp now. Please see it again!

@kvark kvark requested a review from teoxoy November 23, 2024 09:38
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@teoxoy teoxoy merged commit 314e196 into gfx-rs:trunk Nov 27, 2024
27 checks passed
@kvark kvark deleted the rt-constants branch November 28, 2024 03:56
This was referenced Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants