Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL actually supports DEPTH32FLOAT_STENCIL8 #5370

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

Dinnerbone
Copy link
Contributor

@Dinnerbone Dinnerbone commented Mar 9, 2024

Connections
n/a

Description
Noticed this recently, the GL backend didn't allow the use of Depth32FloatStencil8 because the DEPTH32FLOAT_STENCIL8 feature isn't claimed to be supported.

It actually is supported, so this fixes that and allows for the use of Depth32FloatStencil8 on GLES/WebGL.

Testing
I manually changed the stencil test to use Depth32FloatStencil8 and it works as expected.

The wgpu_test::clear_texture::clear_texture_depth32_stencil8 test had to be configured to also require wgpu::DownlevelFlags::DEPTH_TEXTURE_AND_BUFFER_COPIES as that's not supported on the GLES backend, as otherwise that test tries to now run on GLES but fails.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Dinnerbone Dinnerbone requested a review from a team as a code owner March 9, 2024 19:10
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

So yeah, looks like an oversight!
Thanks for all this bite sized (Web)GL but great improvements @Dinnerbone ! 🙇

@Wumpf Wumpf merged commit f78e2f7 into gfx-rs:trunk Mar 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants