wgpu-hal: add ndk-sys dependency to fix linking error. #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue is invisible in the tests, since the dev dependencies include winit which itself depends on ndk-sys when using android.
ashdnazg
commented
Mar 1, 2024
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 1, 2024
Merged
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 1, 2024
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 1, 2024
cwfitzgerald
removed
the
PR: needs back-porting
|
Seeing this from the changelog: any clue why this function is called in the first place? I've played with EGL on Android a fair bit and it always returns configs for all available formats, on devices I've tested. Only when calling Is the assumption that the user may have limited the format before, so that this function is used to change it again, or to make config filtering easier? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compilation of an android library which depends on wgpu fails during linking with the error:
This isn't encountered in the tests, since the dev dependencies include
winitwhich depends onndk-syswhen targeting android.Testing
This was tested by succeeding to compile a project which did not compile previously.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.