Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test that verifies that we can drop the queue before using the device to create a command encoder #5211

Merged
merged 3 commits into from
Feb 9, 2024
Merged

add test that verifies that we can drop the queue before using the device to create a command encoder #5211

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c44096a
add test that verifies that we can drop the queue before using the de…
Davidster Feb 6, 2024
1782cc9
update changelog
Davidster Feb 6, 2024
5a2813f
mark test as always failing
Davidster Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ Bottom level categories:

- Fix intermittent crashes on Linux in the `multithreaded_compute` test. By @jimblandy in [#5129](https://github.com/gfx-rs/wgpu/pull/5129).
- Refactor tests to read feature flags by name instead of a hardcoded hexadecimal u64. By @rodolphito in [#5155](https://github.com/gfx-rs/wgpu/pull/5155).
- Add test that verifies that we can drop the queue before using the device to create a command encoder. By @Davidster in [#5211](https://github.com/gfx-rs/wgpu/pull/5211)

## v0.19.0 (2024-01-17)

Expand Down
8 changes: 8 additions & 0 deletions tests/tests/encoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ static DROP_ENCODER: GpuTestConfiguration = GpuTestConfiguration::new().run_sync
drop(encoder);
});

#[gpu_test]
static DROP_QUEUE_BEFORE_CREATING_COMMAND_ENCODER: GpuTestConfiguration =
GpuTestConfiguration::new().run_sync(|ctx| {
let device = ctx.device.clone();
drop(ctx);
let _encoder = device.create_command_encoder(&wgpu::CommandEncoderDescriptor::default());
});

// This test crashes on DX12 with the exception:
//
// ID3D12CommandAllocator::Reset: The command allocator cannot be reset because a
Expand Down
Loading