Make DeviceLostClosure.from_c mutate the closure before dropping it. #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradwerth
force-pushed
the
callBeforeDropCallbackC
branch
from
e4ff825
to
98c6ec2
Compare
cwfitzgerald
previously requested changes
Jan 11, 2024
nical
approved these changes
Jan 11, 2024
This clarifies that the Rust and C-style callbacks/closures need to be consumed (not called) before they are dropped. It also makes the from_c function consume the param closure so that it can be dropped without panicking. It also relaxes the restriction that the callback/closure can only be called once.
bradwerth
force-pushed
the
callBeforeDropCallbackC
branch
from
98c6ec2
to
4e16f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
DeviceLostClosureCrequires that it be called before it is dropped, and we receive an existingDeviceLostClosureCstruct as param inDeviceLostClosure.from_c, we need to mark the param as called before it drops out of scope.Testing
Tested by embedders using
DeviceLostClosure.from_c.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.