Propagate errors when openning/closing a command encoder #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Jan 6, 2024
|
Device loss is what our CI seemed to be hitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Downstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1873047
Description
There are a few
unwraps inCommandEncoder(with TODO comment about dealing with the errors), which Firefox's fuzzer is too good at hitting. This PR just does the plumbing to propagate the errors instead of packing.Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.