[spv/msl/hlsl-out] support pipeline constant value replacements #4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
pipeline-constants
branch
from
340768e
to
9d72542
Compare
teoxoy
force-pushed
the
pipeline-constants
branch
from
82ebbfd
to
420690a
Compare
teoxoy
force-pushed
the
pipeline-constants
branch
from
9d72542
to
5e4a8f7
Compare
teoxoy
force-pushed
the
pipeline-constants
branch
from
420690a
to
6a494a8
Compare
teoxoy
force-pushed
the
pipeline-constants
branch
from
5e4a8f7
to
6cae486
Compare
cwfitzgerald
approved these changes
Jan 11, 2024
jimblandy
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Okay, this looks good to me.
I have various suggestions. I'll push commits for some of them to teoxoy/wgpu@pipeline-constants...jimblandy:wgpu:pipeline-constants
| params.pipeline_constants.clone(), | ||
| ); | ||
| if !old.is_empty() { | ||
| panic!("Supply pipeline constants via pipeline_constants instead of msl_pipeline.constants!"); |
There was a problem hiding this comment.
In a follow-up, let's try to make the parameters for all the snapshot backends work in the same way.
jimblandy
reviewed
Feb 6, 2024
teoxoy
force-pushed
the
pipeline-constants
branch
from
19a3714
to
e4d71e1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for value replacements of pipeline-overridable constants for our 3 main back-ends.
Tracking meta issue: #4484.