Fix BufferMapRange not being Send/Sync (on native)
#4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
approved these changes
Dec 4, 2023
|
Ah it looks like this requires some more fiddling: https://github.com/gfx-rs/wgpu/actions/runs/7078382332/job/19263794161?pr=4818#step:8:492 |
|
ah missed that! Won't get to it very soon, but will look into it! |
…c-non-atomic-wasm + !atomics
5 tasks
Wumpf
added a commit
to rerun-io/rerun
that referenced
this pull request
Feb 19, 2024
…er (#5225) ### What * This got fixed in gfx-rs/wgpu#4818 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5225/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5225/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5225/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5225) - [Docs preview](https://rerun.io/preview/db9b495d18aec9485ec24c85cf11506d58b0843d/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/db9b495d18aec9485ec24c85cf11506d58b0843d/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes
Description
Fixes
BufferMappedRangetrait not exposing Send/Sync of the underlying impl, i.e it wasn'tWasmNotSendSync.Testing
It compiles!
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.