Implement WGSL abstract types for global `const` declarations and constructor calls. #4743

jimblandy · 2023-11-21T22:47:32Z

Checklist

Run cargo fmt.
Run cargo clippy.
Run cargo xtask test to run tests.
Add change to CHANGELOG.md. See simple instructions inside file.

jimblandy · 2023-11-21T22:49:50Z

This is still dependent on a bunch of other PRs, visible in the merge history. Once those are landed, and I've addressed CI issues, I'll take this out of draft.

jimblandy · 2023-11-22T05:16:39Z

Regarding the mess described in #4747: this PR just deletes tests/in/glsl/double-math-functions.frag for the time being, as it can't be translated to WGSL.

jimblandy · 2023-11-23T18:17:31Z

Since #4747 has landed, this is ready for review.

jimblandy · 2023-11-23T18:21:15Z

By the way - I think we should sometime soon rename Lowerer::expression to concretized_expression, and then rename expression_for_abstract to expression. Since so many operations in WGSL accept abstract types, the "natural" choice should the one that doesn't concretize yet, and code that does concretize should look "suspicious", as potentially in need of an update.

(In #4755 I was confused for a bit by test failures before I realized that I was still automatically concretizing the initialization expression, so that coercion to the var's declared type didn't work.)

But that can be a separate PR, isolated from any semantic changes.

jimblandy · 2023-11-26T22:27:48Z

Hmm. There is a slightly different way to approach this patch, which would be to make constant evaluation responsible for detecting when conversions are necessary and applying them. The WGSL front end is still going to need to do things like choose types for all those Compose expressions in construction.rs, for example, but once it's done so, it seems like the actual conversions could be done directly in constant_evaluator.rs, rather than having the front end create a bunch of As expressions which it trusts the constant evaluator to consume.

@teoxoy If you'd like me to try out that alternative, just let me know. I don't think it'd take long.

teoxoy

Solid stuff!

Left a few suggestions.

naga/src/valid/expression.rs

naga/src/front/wgsl/lower/conversion.rs

naga/src/front/wgsl/lower/construction.rs

naga/src/front/wgsl/lower/conversion.rs

naga/src/front/wgsl/lower/construction.rs

naga/src/front/wgsl/lower/conversion.rs

teoxoy · 2023-11-27T14:47:25Z

Hmm. There is a slightly different way to approach this patch, which would be to make constant evaluation responsible for detecting when conversions are necessary and applying them. The WGSL front end is still going to need to do things like choose types for all those Compose expressions in construction.rs, for example, but once it's done so, it seems like the actual conversions could be done directly in constant_evaluator.rs, rather than having the front end create a bunch of As expressions which it trusts the constant evaluator to consume.

@teoxoy If you'd like me to try out that alternative, just let me know. I don't think it'd take long.

If it's possible that would be great as we are now injecting As expressions that just end up being evaluated by the constant evaluator later anyway.

Introduce new variants of `naga::ScalarKind`, `AbstractInt` and `AbstractFloat`, for representing WGSL abstract types.

Introduce new variants of `naga::Literal`, `AbstractInt` and `AbstractFloat`, for representing WGSL abstract values.

The large `match` statement in `Lowerer::construct` seems to flop back and forth between two indentation levels as it's edited, making the diffs hard to read. Rewrite it to use deferred initialization of `expr`, so that `cargo fmt` doesn't have to decide whether or not to put the `match` on the same line as `let expr`. This makes subsequent diffs easier to read.

Delete the `first_component_ty_inner` field from `front::wgsl::lower::construction::Components::Many`. With the introduction of abstract types, it will no longer be possible to infer the type of the vector being constructed by looking at the type of its first constructor argument alone: automatic conversion rules might need to be applied to that argument.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>

When a constructor builtin has an explicit type parameter, like `mat2x2<f32>`, it should not produce an abstract matrix, even if its arguments are abstract.

jimblandy · 2023-11-29T05:24:45Z

@teoxoy Just added one more commit, nothing else changed.

teoxoy · 2023-11-29T07:58:36Z

Looks good, let's land it.

…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler # Changelog * #4708 Fix max_vertex_buffers validation By nical in gfx-rs/wgpu#4708 * #4729 Remove expected failure on AMD/DX12 from msaa example By teoxoy in gfx-rs/wgpu#4729 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals. By jimblandy in gfx-rs/wgpu#4711 * #4736 Bump serde from 1.0.192 to 1.0.193 By dependabot[bot] in gfx-rs/wgpu#4736 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width. By jimblandy in gfx-rs/wgpu#4735 * #4741 [naga] Fix type error in test. By jimblandy in gfx-rs/wgpu#4741 * #4742 [naga]: Make snapshot tests include paths in errors. By jimblandy in gfx-rs/wgpu#4742 * #4723 Test And Normalize Vertex Behavior on All Backends By cwfitzgerald in gfx-rs/wgpu#4723 * #4746 Skip Flaky Test By cwfitzgerald in gfx-rs/wgpu#4746 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings By bradwerth in gfx-rs/wgpu#4744 * #4745 [naga wgsl-in] Test hex float suffix handling corner case. By jimblandy in gfx-rs/wgpu#4745 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress> By nical in gfx-rs/wgpu#4737 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations. By jimblandy in gfx-rs/wgpu#4733 * #4734 [naga] Make compaction preserve named types, even if unused. By jimblandy in gfx-rs/wgpu#4734 * #4752 Logging cleanups in device/global.rs By nical in gfx-rs/wgpu#4752 * #4753 Fix Mac Event Loop By cwfitzgerald in gfx-rs/wgpu#4753 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER By i509VCB in gfx-rs/wgpu#4754 * #4748 Allow Tests to Expect Certain Panic or Validation Messages By cwfitzgerald in gfx-rs/wgpu#4748 * #4756 Move to A Single Example Executable By cwfitzgerald in gfx-rs/wgpu#4756 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals. By jimblandy in gfx-rs/wgpu#4747 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals. By jimblandy in gfx-rs/wgpu#4747 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature. By jimblandy in gfx-rs/wgpu#4761 * #4769 Conditionally lift API logging from trace to info level By nical in gfx-rs/wgpu#4769 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug By nical in gfx-rs/wgpu#4771 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER` By teoxoy in gfx-rs/wgpu#4760 * #4772 Downgrade resource lifetime management log level to trace. By nical in gfx-rs/wgpu#4772 * #4765 Revamp Examples to Match Website By cwfitzgerald in gfx-rs/wgpu#4765 * #4774 Update examples readme files By roffs in gfx-rs/wgpu#4774 * #4781 remove_abandoned fix By gents83 in gfx-rs/wgpu#4781 * #4777 Bump web-sys to 0.3.65 By torokati44 in gfx-rs/wgpu#4777 * #4780 Fixes for Skybox and All Examples By cwfitzgerald in gfx-rs/wgpu#4780 * #4782 Remove resources ONLY when needed inside wgpu and not in user land By gents83 in gfx-rs/wgpu#4782 * #4786 Don't keep a strong ref in storage for destroyed resources By gents83 in gfx-rs/wgpu#4786 * #4795 Fix Arcanization changelog By a1phyr in gfx-rs/wgpu#4795 * #4794 Delete/rename now-unused gpu.rs By exrook in gfx-rs/wgpu#4794 * #4794 Delete/rename now-unused gpu.rs By exrook in gfx-rs/wgpu#4794 * #4573 Support nv12 texture format By xiaopengli89 in gfx-rs/wgpu#4573 * #4789 Bump js-sys from 0.3.65 to 0.3.66 By dependabot[bot] in gfx-rs/wgpu#4789 * #4784 Bump winit from 0.29.3 to 0.29.4 By dependabot[bot] in gfx-rs/wgpu#4784 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0 By dependabot[bot] in gfx-rs/wgpu#4798 * #4800 Bump web-sys from 0.3.65 to 0.3.66 By dependabot[bot] in gfx-rs/wgpu#4800 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39 By dependabot[bot] in gfx-rs/wgpu#4799 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning) By Wumpf in gfx-rs/wgpu#4796 * #4804 Add space to a comment inside make_spirv_raw By ComfyFluffy in gfx-rs/wgpu#4804 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message. By jimblandy in gfx-rs/wgpu#4805 * #4801 update deno By crowlKats in gfx-rs/wgpu#4801 * #4806 Fixes and changes to the documentation for increasing clarity By Blatko1 in gfx-rs/wgpu#4806 * #4809 [naga wgsl-in] Use a better span for errors in constructors. By jimblandy in gfx-rs/wgpu#4809 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages. By jimblandy in gfx-rs/wgpu#4808 * #4822 Fix expected error message By teoxoy in gfx-rs/wgpu#4822 * #4759 Add feature float32-filterable By almarklein in gfx-rs/wgpu#4759 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3 By dependabot[bot] in gfx-rs/wgpu#4813 Differential Revision: https://phabricator.services.mozilla.com/D195438

…7ab0a860eec. r=webgpu-reviewers,supply-chain-reviewers,ErichDonGubler # Changelog * #4708 Fix max_vertex_buffers validation By nical in gfx-rs/wgpu#4708 * #4729 Remove expected failure on AMD/DX12 from msaa example By teoxoy in gfx-rs/wgpu#4729 * #4711 [naga] Add `Literal::I64`, for signed 64-bit integer literals. By jimblandy in gfx-rs/wgpu#4711 * #4736 Bump serde from 1.0.192 to 1.0.193 By dependabot[bot] in gfx-rs/wgpu#4736 * #4735 [naga]: Let `TypeInner::Matrix` hold a `Scalar`, not just a width. By jimblandy in gfx-rs/wgpu#4735 * #4741 [naga] Fix type error in test. By jimblandy in gfx-rs/wgpu#4741 * #4742 [naga]: Make snapshot tests include paths in errors. By jimblandy in gfx-rs/wgpu#4742 * #4723 Test And Normalize Vertex Behavior on All Backends By cwfitzgerald in gfx-rs/wgpu#4723 * #4746 Skip Flaky Test By cwfitzgerald in gfx-rs/wgpu#4746 * #4744 Ensure DeviceLostClosureC callbacks have null-terminated message strings By bradwerth in gfx-rs/wgpu#4744 * #4745 [naga wgsl-in] Test hex float suffix handling corner case. By jimblandy in gfx-rs/wgpu#4745 * #4737 Make the command_encoder_clear_buffer's size an Option<BufferAddress> By nical in gfx-rs/wgpu#4737 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4701 [naga msl-out] Emit and init `struct` member padding always By ErichDonGubler in gfx-rs/wgpu#4701 * #4733 [naga wgsl-in] Preserve type names in `alias` declarations. By jimblandy in gfx-rs/wgpu#4733 * #4734 [naga] Make compaction preserve named types, even if unused. By jimblandy in gfx-rs/wgpu#4734 * #4752 Logging cleanups in device/global.rs By nical in gfx-rs/wgpu#4752 * #4753 Fix Mac Event Loop By cwfitzgerald in gfx-rs/wgpu#4753 * #4754 wgpu-hal(vk): Add WGPU_ALLOW_NONCOMPLIANT_ADAPTER By i509VCB in gfx-rs/wgpu#4754 * #4748 Allow Tests to Expect Certain Panic or Validation Messages By cwfitzgerald in gfx-rs/wgpu#4748 * #4756 Move to A Single Example Executable By cwfitzgerald in gfx-rs/wgpu#4756 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals. By jimblandy in gfx-rs/wgpu#4747 * #4747 [naga wgsl-in] Experimental 64-bit floating-point literals. By jimblandy in gfx-rs/wgpu#4747 * #4761 [naga] Make the `example_wgsl` test build without `wgsl-in` feature. By jimblandy in gfx-rs/wgpu#4761 * #4769 Conditionally lift API logging from trace to info level By nical in gfx-rs/wgpu#4769 * #4771 Downgrade some of wgpu_core's logging level from info to trace and debug By nical in gfx-rs/wgpu#4771 * #4760 Rename `ALLOW_NONCOMPLIANT_ADAPTER` to `ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER` By teoxoy in gfx-rs/wgpu#4760 * #4772 Downgrade resource lifetime management log level to trace. By nical in gfx-rs/wgpu#4772 * #4765 Revamp Examples to Match Website By cwfitzgerald in gfx-rs/wgpu#4765 * #4774 Update examples readme files By roffs in gfx-rs/wgpu#4774 * #4781 remove_abandoned fix By gents83 in gfx-rs/wgpu#4781 * #4777 Bump web-sys to 0.3.65 By torokati44 in gfx-rs/wgpu#4777 * #4780 Fixes for Skybox and All Examples By cwfitzgerald in gfx-rs/wgpu#4780 * #4782 Remove resources ONLY when needed inside wgpu and not in user land By gents83 in gfx-rs/wgpu#4782 * #4786 Don't keep a strong ref in storage for destroyed resources By gents83 in gfx-rs/wgpu#4786 * #4795 Fix Arcanization changelog By a1phyr in gfx-rs/wgpu#4795 * #4794 Delete/rename now-unused gpu.rs By exrook in gfx-rs/wgpu#4794 * #4794 Delete/rename now-unused gpu.rs By exrook in gfx-rs/wgpu#4794 * #4573 Support nv12 texture format By xiaopengli89 in gfx-rs/wgpu#4573 * #4789 Bump js-sys from 0.3.65 to 0.3.66 By dependabot[bot] in gfx-rs/wgpu#4789 * #4784 Bump winit from 0.29.3 to 0.29.4 By dependabot[bot] in gfx-rs/wgpu#4784 * #4798 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0 By dependabot[bot] in gfx-rs/wgpu#4798 * #4800 Bump web-sys from 0.3.65 to 0.3.66 By dependabot[bot] in gfx-rs/wgpu#4800 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4743 Implement WGSL abstract types for global `const` declarations and constructor calls. By jimblandy in gfx-rs/wgpu#4743 * #4799 Bump wasm-bindgen-futures from 0.4.38 to 0.4.39 By dependabot[bot] in gfx-rs/wgpu#4799 * #4796 Remove surface extent validation (and thus fix the annoying `Requested size ... is outside of the supported range` warning) By Wumpf in gfx-rs/wgpu#4796 * #4804 Add space to a comment inside make_spirv_raw By ComfyFluffy in gfx-rs/wgpu#4804 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4803 `features`/`limits` refactors By teoxoy in gfx-rs/wgpu#4803 * #4805 [naga] Improve ConstantEvaluatorError::InvalidCastArg message. By jimblandy in gfx-rs/wgpu#4805 * #4801 update deno By crowlKats in gfx-rs/wgpu#4801 * #4806 Fixes and changes to the documentation for increasing clarity By Blatko1 in gfx-rs/wgpu#4806 * #4809 [naga wgsl-in] Use a better span for errors in constructors. By jimblandy in gfx-rs/wgpu#4809 * #4808 [naga wgsl-in] Drop spanless labels from front-end error messages. By jimblandy in gfx-rs/wgpu#4808 * #4822 Fix expected error message By teoxoy in gfx-rs/wgpu#4822 * #4759 Add feature float32-filterable By almarklein in gfx-rs/wgpu#4759 * #4813 Bump core-graphics-types from 0.1.2 to 0.1.3 By dependabot[bot] in gfx-rs/wgpu#4813 Differential Revision: https://phabricator.services.mozilla.com/D195438 UltraBlame original commit: 985aabb5bf419ffcc9248010353ff190c225ba61

jimblandy requested a review from a team as a code owner November 21, 2023 22:47

jimblandy marked this pull request as draft November 21, 2023 22:47

jimblandy added area: validation Issues related to validation, diagnostics, and error handling kind: feature naga Shader Translator area: naga front-end lang: WGSL WebGPU Shading Language labels Nov 21, 2023

jimblandy force-pushed the abstract-types-in-ir branch 3 times, most recently from d987602 to ac7c4ff Compare November 22, 2023 04:43

jimblandy force-pushed the abstract-types-in-ir branch 4 times, most recently from 5d5b901 to cfab70f Compare November 22, 2023 22:43

jimblandy mentioned this pull request Nov 23, 2023

[naga wgsl-in] Automatic conversions for var initializers. #4755

Merged

4 tasks

jimblandy force-pushed the abstract-types-in-ir branch from cfab70f to 00ddd26 Compare November 23, 2023 18:16

jimblandy marked this pull request as ready for review November 23, 2023 18:17

jimblandy requested a review from a team as a code owner November 23, 2023 18:17

jimblandy force-pushed the abstract-types-in-ir branch from 00ddd26 to 8ac6215 Compare November 25, 2023 22:36

teoxoy reviewed Nov 27, 2023

View reviewed changes

jimblandy added 4 commits November 27, 2023 13:10

[naga] Introduce ScalarKind::AbstractInt and AbstractFloat.

5064630

Introduce new variants of `naga::ScalarKind`, `AbstractInt` and `AbstractFloat`, for representing WGSL abstract types.

[naga] Introduce Literal::AbstractInt and AbstractFloat.

221185a

Introduce new variants of `naga::Literal`, `AbstractInt` and `AbstractFloat`, for representing WGSL abstract values.

jimblandy force-pushed the abstract-types-in-ir branch 3 times, most recently from 5789746 to 4d15377 Compare November 27, 2023 21:28

[naga wgsl-in] Implement abstract types for consts, constructors.

d1519b5

jimblandy force-pushed the abstract-types-in-ir branch from 73f51e0 to c7cf770 Compare November 27, 2023 21:37

[naga wgsl-in] Clarify match in automatic_conversion_join.

a3911b5

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>

jimblandy force-pushed the abstract-types-in-ir branch from c7cf770 to a3911b5 Compare November 28, 2023 01:25

jimblandy added 2 commits November 27, 2023 18:16

[naga] Improve snapshot output when validation fails.

081028d

[naga wgsl-in] Matrix constructors have only float overloads.

45dc411

teoxoy approved these changes Nov 28, 2023

View reviewed changes

[naga wgsl-in] Constructors with types don't make abstract values.

ffa8d16

When a constructor builtin has an explicit type parameter, like `mat2x2<f32>`, it should not produce an abstract matrix, even if its arguments are abstract.

jimblandy requested a review from teoxoy November 29, 2023 05:24

teoxoy merged commit 5a3887a into gfx-rs:trunk Nov 29, 2023
27 checks passed

jimblandy deleted the abstract-types-in-ir branch December 13, 2023 16:31

teoxoy mentioned this pull request Jan 2, 2024

Wgsl struct constructor failed #4953

Closed

teoxoy added the type: enhancement New feature or request label Jul 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement WGSL abstract types for global `const` declarations and constructor calls. #4743

Implement WGSL abstract types for global `const` declarations and constructor calls. #4743

jimblandy commented Nov 21, 2023 •

edited

Loading

jimblandy commented Nov 21, 2023

jimblandy commented Nov 22, 2023

jimblandy commented Nov 23, 2023

jimblandy commented Nov 23, 2023

jimblandy commented Nov 26, 2023

teoxoy left a comment

teoxoy commented Nov 27, 2023

jimblandy commented Nov 29, 2023

teoxoy commented Nov 29, 2023

Implement WGSL abstract types for global const declarations and constructor calls. #4743

Implement WGSL abstract types for global const declarations and constructor calls. #4743

Conversation

jimblandy commented Nov 21, 2023 • edited Loading

jimblandy commented Nov 21, 2023

jimblandy commented Nov 22, 2023

jimblandy commented Nov 23, 2023

jimblandy commented Nov 23, 2023

jimblandy commented Nov 26, 2023

teoxoy left a comment

Choose a reason for hiding this comment

teoxoy commented Nov 27, 2023

jimblandy commented Nov 29, 2023

teoxoy commented Nov 29, 2023

Implement WGSL abstract types for global `const` declarations and constructor calls. #4743

Implement WGSL abstract types for global `const` declarations and constructor calls. #4743

jimblandy commented Nov 21, 2023 •

edited

Loading