Check if source is empty when constructing hal::DebugSource (0.18 backport)
#4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From where I'm sitting this seems to have worked better, next time I'll use git cherry-pick like a normal person lol |
cwfitzgerald
approved these changes
Nov 15, 2023
cwfitzgerald
pushed a commit
that referenced
this pull request
Nov 15, 2023
… backport) (#4693) Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this correct? I mostly based it on what @mcclure did in #4649, though I did
git cherry-pickrather thanhg graft.Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
This is the commit from #4642 cherry-picked onto a branch forked from the v0.18 branch, targeting that branch in gfx-rs/wgpu.
Testing
Tested the code example from #4569 with danielhjacobs@dfdb2f1 vs with https://github.com/gfx-rs/wgpu/tree/v0.18 (changing
let module = naga::front::wgsltolet module = wgpu::naga::front::wgslin the code example to fix the issue "note:naga::Moduleandwgpu::naga::Modulehave similar names, but are actually distinct types") and saw the panic was gone with this commit.