Make GLES optional on Windows & macOS #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm hesitant to go forward with this - this seems to be moving in the opposite direction of what we want. We were trying to make features work on all platforms so that the features can be enabled everywhere (also removing the need for the second resolver). I do agree we probably shouldn't have angle enabled by default, but this may not be the right way. I'm not sure what the right way is though. |
|
I haven't added any restrictions though, only made the GLES backend optional by default on the platforms that need Angle. This is similar to |
cwfitzgerald
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
#4109 (comment)
Description
Users of GLES on Windows and macOS should have to opt into using the GLES backend via Angle since they'd have to package it with the app. Otherwise we might pick up a random version of Angle on their system.