Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Metal from crashing when a still-open encoder is deallocated, resolve issue #2077. #4023

Merged
merged 22 commits into from
Aug 29, 2023
Merged

Prevent Metal from crashing when a still-open encoder is deallocated, resolve issue #2077. #4023

merged 22 commits into from
Aug 29, 2023

Commits on Aug 9, 2023

  1. This prevents Metal from crashing when an encoder is deallocated.

    @bradwerth
    bradwerth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    75b5056 View commit details
    Browse the repository at this point in the history

  2. Add note to CHANGELOG.md.

    @bradwerth
    bradwerth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7ce2f9a View commit details
    Browse the repository at this point in the history

  3. Add note to CHANGELOG.md.

    @bradwerth
    bradwerth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    baf3fa3 View commit details
    Browse the repository at this point in the history

  4. Relocate additions in CHANGELOG.md.

    @bradwerth
    bradwerth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7e21d4c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'endEncoding' of https://github.com/bradwerth/wgpu into … 

    …endEncoding
    @bradwerth
    bradwerth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d896931 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Fix changelog and add code comment describing the motivation for thes… 

    …e changes.
    @bradwerth
    bradwerth committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    db5cb6d View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    386eacc View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Instead of implementing Drop for CommandState, implement it for 

    CommandEncoder such that we can call the existing discard_encoding
function. Also add a test of dropping a CommandEncoder after it has
errored on a command.
    @bradwerth
    bradwerth committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0425f63 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    00411bc View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Implement Drop for DX12 CommandEncoders to also call discard_encoding.

    @bradwerth
    bradwerth committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a4eaa94 View commit details
    Browse the repository at this point in the history

  2. Update Changelog with notes about DX12 changes.

    @bradwerth
    bradwerth committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c4d5691 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3c44ed7 View commit details
    Browse the repository at this point in the history

  4. Fix DX12 compilation problems, attempt 1.

    @bradwerth
    bradwerth committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    9f55d32 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2cbb242 View commit details
    Browse the repository at this point in the history

  6. Update comment with the narrower finding of the endEncoding requirement.

    @bradwerth
    bradwerth committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    59446b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Mark the drop_encoder_after_error test as failing on DX12.

    @bradwerth
    bradwerth committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    305fd55 View commit details
    Browse the repository at this point in the history

  2. Cleanup of some should-be-left-untouched DX12 implementation stuff.

    @bradwerth
    bradwerth committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    64a029f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    dd53269 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7215c93 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bdb4515 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Merge branch 'trunk' into endEncoding

    @bradwerth
    bradwerth authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    e3afadc View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. CHANGELOG.md: Avoid duplicating "Bug Fixes" section

    @jimblandy
    jimblandy committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3e2ec42 View commit details
    Browse the repository at this point in the history