Update RenderPass draw, draw_indexed, set_viewport and set_scissor_rect documentation #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 12, 2023 11:27
… relate them as framebuffer space.
genusistimelord
changed the title
|
This does not fully fix #3852 but it is a good start at least. |
Wumpf
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Thank you so much for contributing and getting the docs to a better place!
Really like the cross references!
I think though it's super important that the descriptions here are razor sharp and correct for all cases, so there's some more work needed here.
Generally I'd encourage to copy paste from the webgpu spec!
…what wumpf suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully make the documentation a bit better and more understandable for these functions. Please let me know what you like or dislike about this and anything I can fix or improve upon if i was wrong in some way.