Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add link feature #3853

Merged
merged 2 commits into from
Jun 28, 2023
Merged

feat: add link feature #3853

merged 2 commits into from
Jun 28, 2023

Conversation

crowlKats
Copy link
Collaborator

This first requires a release of metal-rs

@Wumpf
Copy link
Member

Wumpf commented Jun 10, 2023

What does this do?

@crowlKats
Copy link
Collaborator Author

@Wumpf here is the discussion that prompted this: https://matrix.to/#/!FZyQrssSlHEZqrYcOb:matrix.org/$p_e4sAf-9ghc9fGryzvdu1mQnPXmMCkyerIW7D3jrbM?via=matrix.org&via=mozilla.org&via=fairydust.space

cwfitzgerald
cwfitzgerald approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we get a bit of documentation about what the feature is?

@crowlKats
Copy link
Collaborator Author

@cwfitzgerald sure; done. We need a metal-rs release first before landing though; is this something you could do?

@crowlKats crowlKats merged commit 973cd3e into gfx-rs:trunk Jun 28, 2023
20 checks passed
@crowlKats crowlKats deleted the link_feature branch June 28, 2023 10:30
@crowlKats crowlKats mentioned this pull request Jun 30, 2023
Merged
@teoxoy teoxoy mentioned this pull request Oct 10, 2023
Closed
This was referenced May 23, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowlKats @Wumpf @cwfitzgerald