Fix unsetting vertex attributes in gles backend #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
bevyengine/bevy#5732 (and all linked issues)
Description
Currently, the code responsible for un-setting vertex attributes uses the attribute's index in the state's array.
Instead we need to use the location of the vertex attribute.
This was causing issues with apps running in wasm on the webgl backend, such as bevy apps.
Testing
I tweaked the test from issue #3457 to use non-consecutive vertex attribute locations. This covers the code path that unsets attribs at the end of a render pass, but does not cover the code path that unsets them upon switching to a new pipeline.
Unfortunately I didn't manage to test that one (unsetting upon pipeline switching), because the webgl context fails silently in that case.