Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate before extracting texture selectors #3487

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Validate before extracting texture selectors #3487

merged 2 commits into from
Feb 14, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 14, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description

Testing
Updated test.

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Feb 14, 2023
jimblandy
jimblandy approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, makes sense.

@jimblandy jimblandy merged commit b33731c into gfx-rs:master Feb 14, 2023
@teoxoy teoxoy deleted the always-validate-copy-range-before branch February 14, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
WebGPU Specification V1
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @jimblandy