Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add indirect execution to vulkan downlevel flags #3319

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Re-add indirect execution to vulkan downlevel flags #3319

merged 1 commit into from
Dec 20, 2022

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Closes #3318

Indirect execution is guaranteed.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 20, 2022 20:58
teoxoy
teoxoy approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I double checked and this is the only one that I missed.
Thanks for adding it back!

@cwfitzgerald
Copy link
Member Author

Thanks for double checking!

@cwfitzgerald cwfitzgerald merged commit 4c5fef4 into gfx-rs:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INDIRECT_EXECUTION downlevel flag not set on 2080SUPER, driver 527.56, vulkan backend
2 participants
@cwfitzgerald @teoxoy