Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DEPTH_BIAS_CLAMP and FULL_DRAW_INDEX_UINT32 downlevel flags #3316

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Dec 20, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description
Added missing Vulkan/GLES downlevel flags.
Do note that we don't validate FULL_DRAW_INDEX_UINT32 because we'd have to go through all values in the index buffers and check them.

Testing

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 20, 2022
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus nit

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #3316 (e902508) into master (c91cae4) will increase coverage by 0.02%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##           master    #3316      +/-   ##
==========================================
+ Coverage   64.28%   64.30%   +0.02%     
==========================================
  Files          83       83              
  Lines       42274    42302      +28     
==========================================
+ Hits        27176    27204      +28     
  Misses      15098    15098              
Impacted Files Coverage Δ
wgpu-hal/src/dx11/adapter.rs 0.00% <0.00%> (ø)
wgpu-types/src/lib.rs 88.30% <ø> (ø)
wgpu-core/src/device/mod.rs 66.68% <75.00%> (+<0.01%) ⬆️
wgpu-hal/src/gles/adapter.rs 84.07% <100.00%> (+0.11%) ⬆️
wgpu-hal/src/vulkan/adapter.rs 77.77% <100.00%> (+0.26%) ⬆️
wgpu-core/src/hub.rs 60.82% <0.00%> (+0.15%) ⬆️
wgpu-core/src/instance.rs 66.43% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@teoxoy teoxoy merged commit 62e932b into gfx-rs:master Dec 20, 2022
@teoxoy teoxoy deleted the add-missing-DownlevelFlags branch December 20, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants