Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dynamic offset binding errors #3294

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

This is very often complained about by users.

Description

Vastly improves the amount of information in dynamic binding offset errors.

Testing

Locally checked shadow example.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 15, 2022 00:48
@cwfitzgerald cwfitzgerald merged commit 3ce5ca8 into gfx-rs:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant