Test and doc tweaks #3149
Merged
Test and doc tweaks #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror scopes (instead of accidentally just testing the first one).
vulkan, dx12, and metal.
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
==========================================
- Coverage 65.41% 64.73% -0.69%
==========================================
Files 81 81
Lines 38763 38737 -26
==========================================
- Hits 25358 25076 -282
- Misses 13405 13661 +256
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RunRUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Add change to CHANGELOG.md. See simple instructions inside file.Connections
This fixes a bug I noticed in a test I added in a previous PR: see this comment #3023 (comment)
Description
Instead of using panics to catch validation errors, the buffer usage test now uses error scopes. This is more amenable to not re-creating the whole context for each test case that is intended to fail.
This PR also modifies the docs of
Feature::MAPPABLE_PRIMARY_BUFFERto indicate that it is only available on Vulkan, DX12, and Metal.