Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL2 multiview support via OVR_multiview2 #3121

Merged
merged 4 commits into from
Oct 18, 2022
Merged

WebGL2 multiview support via OVR_multiview2 #3121

merged 4 commits into from
Oct 18, 2022

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Oct 17, 2022 •
edited
Loading

Checklist

Built on top of gfx-rs/naga#1933.

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Testing

I've been using it extensively in my own code.

cwfitzgerald
cwfitzgerald approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@cwfitzgerald cwfitzgerald marked this pull request as draft October 18, 2022 16:13
@cwfitzgerald cwfitzgerald marked this pull request as ready for review October 18, 2022 16:13
cwfitzgerald
cwfitzgerald reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is totally confused, but last commit passed, so forcing it through

@cwfitzgerald cwfitzgerald merged commit d3ab5a1 into gfx-rs:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expenses @cwfitzgerald