Fill in Adapter::as_hal and Device::as_hal documentation. #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
doc-as-hal-callback
branch
from
02df4e8
to
c6d4df7
Compare
cwfitzgerald
approved these changes
Aug 28, 2022
jimblandy
force-pushed
the
doc-as-hal-callback
branch
from
c6d4df7
to
666d3ac
Compare
In particular, explain why a callback is needed, rather than just having these functions return an `Option<&A::Mumble>`.
jimblandy
force-pushed
the
doc-as-hal-callback
branch
from
666d3ac
to
af8c4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, explain why a callback is needed, rather than just
having these functions return an
Option<&A::Mumble>.Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.