Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always free staging buffers #2961

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Always free staging buffers #2961

merged 4 commits into from
Aug 14, 2022

Commits on Aug 14, 2022

  1. Have prepare_staging_buffer take a raw hal Device. 

    This helps the borrow checker understand that we can borrow
`pending_writes`'s encoder and the raw Device at the same time.
    @jimblandy
    jimblandy committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    cedeaac View commit details
    Browse the repository at this point in the history

  2. Always free staging buffers. 

    We must ensure that the staging buffer is not leaked when an error
occurs, so allocate it as late as possible, and free it explicitly when
those fallible operations we can't move it past go awry.

Fixes gfx-rs#2959.
    @jimblandy
    jimblandy committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    6a671ef View commit details
    Browse the repository at this point in the history

  3. Some tests for texture and buffer copies.

    @jimblandy
    jimblandy committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    d34690a View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG.md entry.

    @jimblandy
    jimblandy committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    9022850 View commit details
    Browse the repository at this point in the history