vulkan: fix issues querying multiview support #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
force-pushed
the
vk-multiview-1.0
branch
from
d68b495
to
f00aa0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
This starts part of #2925 by removing no longer using
VkPhysicalDeviceVulkan11Features. VkPhysicalDeviceVulkan11Features may imply availability in Vulkan 1.1, but confusingly it is only first available in Vulkan 1.2. Vulkan 1.1 supports chaining theVkPhysicalDeviceMultiviewFeaturestype, which is aliased by the KHR name to get this information instead. It is cleaner for the implementation to chain specific feature/properties structures instead of switching between the specific and Vulkan1X feature/properties structures.Description
The Vulkan hal did not chain
VkPhysicalDeviceMultiviewFeaturesto theVkDeviceCreateInfo. This meant that with drivers that only support Vulkan 1.0 and VK_KHR_multiview would false report no support for theMULTIVIEWfeature.