added downlevel restriction error message for InvalidFormatUsages error #2886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
link to issue
Description
As mentioned in the issue, texture format usages that are not possible due to downlevel incompatibility have the same error message as if a usage incompatible with the WebGPU specification is specified. This PR adds a third parameter to the InvalidFormatUsages error, specifying if the error was due to a downlevel incompatibility. Additionally this third parameter is populated by checking against the webgpu allowed usages for the texture format in question.
Testing
This PR was tested by running
where device is of type wgpu::Device.
This is within the specification, and within the format features table, however unsupported by the hardware I'm running.
The observed error message is
Additionally to assert that the original error message without downlevel restrictions is behaving correctly the below snippet was run
This is both outside the specification and the table referenced. The error observed in this case is