Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: restrict hal::TextureUses::COLOR_TARGET condition within create_texture #2818

Merged
merged 1 commit into from
Jun 28, 2022
Merged

core: restrict hal::TextureUses::COLOR_TARGET condition within create_texture #2818

merged 1 commit into from
Jun 28, 2022

Conversation

jinleili
Copy link
Contributor

Connections
#2794

Description
The WebGPU Spec says:

A GPUTextureView view is a renderable texture view if the following requirements are met:
view.[[texture]].usage must contain RENDER_ATTACHMENT.
descriptor.dimension must be "2d".

So that failure was more about alignment with spec.

Testing
Tested on macOS with METAL_DEVICE_WRAPPER_TYPE=1 cargo nextest run --all --no-fail-fast

@jinleili
Copy link
Contributor Author

I encountered rare CI failure again :)

cwfitzgerald
cwfitzgerald approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald
Copy link
Member

Different error this time :)

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 28, 2022 18:12
@cwfitzgerald cwfitzgerald merged commit b0c7986 into gfx-rs:master Jun 28, 2022
@cwfitzgerald cwfitzgerald mentioned this pull request Jun 28, 2022
Closed
@jinleili jinleili deleted the render_attachment branch June 28, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @cwfitzgerald