Use numeric constants to define wgpu_types::Features values.
#2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an incidental change, wgpu#2802 (de5fe90) changed the definitions of the bitflags in `wgpu_types::Features` from looking like this: const DEPTH24UNORM_STENCIL8 = 1 << 1; to this: const DEPTH24UNORM_STENCIL8 = Self::DEPTH_CLIP_CONTROL.bits << 1; The intention was to make it easier to insert new flags at a logical point in the list, and have the numbers automatically update themselves. Unfortunately, `cbindgen` can't cope with the new style of definition. It produces definitions for these flags that look like this: #define WGPUFeatures_DEPTH24UNORM_STENCIL8 (uint64_t)((WGPUFeatures_DEPTH_CLIP_CONTROL).bits << 1) These are integer values, so the `.bits` field access is bogus. This commit changes the definitions back to using direct numbering, which `cbindgen` doesn't choke on.
|
Ah rip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an incidental change, #2802 (de5fe90) changed the definitions of the bitflags in
wgpu_types::Featuresfrom looking like this:to this:
The intention was to make it easier to insert new flags at a logical point in the list, and have the numbers automatically update themselves.
Unfortunately,
cbindgencan't cope with the new style of definition. It produces definitions for these flags that look like this:These are integer values, so the
.bitsfield access is bogus.This commit changes the definitions back to using direct numbering, which
cbindgendoesn't choke on.