Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve read-write and read-only texture storage error message #2745

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Improve read-write and read-only texture storage error message #2745

merged 2 commits into from
Jun 7, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jun 7, 2022 •
edited by cwfitzgerald
Loading

Connections
Closes #2735

Testing
Tested locally

cwfitzgerald
cwfitzgerald approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM plus nits

wgpu-core/src/binding_model.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 7, 2022 06:06
@cwfitzgerald cwfitzgerald merged commit f0c7fe3 into gfx-rs:master Jun 7, 2022
@jinleili jinleili deleted the err_msg branch June 7, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read/Write and Read-Only Storage Texture Error Message Doesn't Say Why
2 participants
@jinleili @cwfitzgerald