Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Features::MULTI_DRAW_INDIRECT to Metal #2737

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Jun 6, 2022

Description

We currently emulate MDI in Metal on top of draw_primitives_indirect:

for _ in 0..draw_count {
encoder.draw_primitives_indirect(self.state.raw_primitive_type, &buffer.raw, offset);
offset += mem::size_of::<wgt::DrawIndirectArgs>() as wgt::BufferAddress;
}

Therefore we might as well expose the feature as long as it's clear that it's emulated and not natively supported.

Testing

I don't have my Macbook on me at the moment but I can test it on that when I get home.

@cwfitzgerald cwfitzgerald merged commit 717bc40 into gfx-rs:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants