Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGL] Add a downlevel capability for rendering to floating point textures #2729

Merged
merged 10 commits into from
Jun 14, 2022
Merged

[WebGL] Add a downlevel capability for rendering to floating point textures #2729

merged 10 commits into from
Jun 14, 2022

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Jun 3, 2022

Description

The EXT_color_buffer_float extension let's you rendering to floating point textures.

Not sure if passing the entire capabilities struct to the adapter is the way to go.

cwfitzgerald
cwfitzgerald requested changes Jun 4, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the problem you identified, but otherwise looks okay

wgpu-hal/src/dx11/adapter.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald requested changes Jun 5, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend works LGTM, comments on how we expose it

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/mod.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N-th time's the charm

wgpu-hal/src/dx11/adapter.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 14, 2022 04:43
@cwfitzgerald cwfitzgerald merged commit a880eb9 into gfx-rs:master Jun 14, 2022
@expenses expenses mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expenses @cwfitzgerald