Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metal: fix Depth24Plus | Depth24PlusStencil8 capabilities #2686

Merged
merged 1 commit into from
May 22, 2022
Merged

metal: fix Depth24Plus | Depth24PlusStencil8 capabilities #2686

merged 1 commit into from
May 22, 2022

Conversation

jinleili
Copy link
Contributor

Description
Since Depth24Plus Depth24PlusStencil8 always map to Depth24Unorm_Stencil8 || Depth32Float and Depth24Unorm_Stencil8 || Depth32Float_Stencil8 respectively,

wgpu/wgpu-hal/src/metal/adapter.rs

Lines 894 to 907 in 84efe2b

Tf::Depth24Plus => {
if self.format_depth24_stencil8 {
Depth24Unorm_Stencil8
} else {
Depth32Float
}
}
Tf::Depth24PlusStencil8 => {
if self.format_depth24_stencil8 {
Depth24Unorm_Stencil8
} else {
Depth32Float_Stencil8
}
}

so capabilities also need map to too:
截屏2022-05-22 14 00 53

@kvark kvark merged commit eb260ba into gfx-rs:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @kvark