Accept both parking-lot 0.11 and 0.12, to avoid windows-rs. #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firefox is trying to put off taking the |
cwfitzgerald
requested changes
May 15, 2022
jimblandy
force-pushed
the
accept-parking-lot-11
branch
from
c8436a6
to
de7cd72
Compare
cwfitzgerald
requested changes
May 16, 2022
In parking_lot 0.12 and parking_lot_core 0.9.0, those crates switched from the winapi crate to the official Microsoft windows-sys crate. This is fine, except that windows-sys and its dependencies are even larger than winapi. Some users may wish to stick with winapi for the time being; this change allows wgpu to accommodate them.
jimblandy
force-pushed
the
accept-parking-lot-11
branch
from
de7cd72
to
6d90a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parking_lot 0.12 and parking_lot_core 0.9.0, those crates switched from the winapi crate to the official Microsoft windows-sys crate. This is fine, except that windows-sys and its dependencies are even larger than winapi. Some users may wish to stick with winapi for the time being; this change allows wgpu to accommodate them.