Fix incorrect filtering used in mipmap generation #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Difference in behavior in my application between these sampling modes making use of this example's code. Nearest: Linear: |
|
Doh! That's a big one, good catch. You need to regenerate the rest screenshot to get ci to pass. Go to wgpu/examples/mipmap/screenshot.png and delete it, then run |
|
Interesting how this went on unnoticed. Good catch! |
cwfitzgerald
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min filtering setting is used to down-sample, this is what is used for mipmap generation in this example. It was set to
Nearestwhich will pick one of the pixels, which is incorrect behavior for down-sampling.Linearcorrectly averages the 4 pixels when down-sampling.