Wrap all validation logs with catch_unwinds #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging, uncontroversial |
cwfitzgerald
force-pushed
the
wrap-validation-log-callbacks
branch
from
038f076
to
b5b8640
Compare
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Apr 19, 2022
kvark
pushed a commit
that referenced
this pull request
Apr 20, 2022
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #2487
Description
Wraps all log calls with catch_unwind on VK, GL, and DX12
Testing
Unneeded