Fix Surface::frome_uiview can not guarantee set correct contentScaleFactor
#2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view's contentScaleFactor
kvark
approved these changes
Feb 10, 2022
kvark
added
the
PR: needs back-porting
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On iOS,
Surface::from_uiviewmay be called before the application initialization is complete (when using winit to manage windows and events),msg_send![view, window]ormsg_send![window, screen]will get null, then, view'scontentScaleFactorremain default 1. The correct value should be between [2.0, 3.0], depending on physical device.from_uiviewis the same asfrom_nsviewmore than half of code, so, merged together.Testing
Tested wgpu + winit on iOS, follow the implementation of bevy's iOS demo.
Tested winit-free mode on iOS, use wgpu-on-app.
Tested all Wgpu's examples on M1 Mac(macOS 12.2)