Fix M1 in macOS incorrectly reports supported compressed texture formats #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2022
cwfitzgerald
reviewed
Feb 4, 2022
superdump
force-pushed
the
apple-m1-texture-compression
branch
from
f9ffe4c
to
974b5d3
Compare
kvark
approved these changes
Feb 4, 2022
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
M1 in macOS incorrectly reports supported compressed texture formats
Description
The metal backend in wgpu-hal was incorrectly detecting support for ASTC and EAC/ETC2 on macOS as the M1 line of GPUs supports these formats as well as BC. It was also misrepresenting the support in the values returned from
Adapter::features()as always support BC and never ASTC nor ETC2.Testing
On an M1 running macOS, check whether the
Adapter::features()includes all three ofTEXTURE_COMPRESSION_ASTC,TEXTURE_COMPRESSION_BC, andTEXTURE_COMPRESSION_ETC2. I have tested this locally on an M1 Max running macOS.