Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx11 Backend #2443

Merged
merged 9 commits into from
Mar 12, 2022
Merged

Dx11 Backend #2443

merged 9 commits into from
Mar 12, 2022

Conversation

cwfitzgerald
Copy link
Member

Description

At long last here is the PR that begins the Dx11 api. I'm making this PR early to make progress transparent and encourage comments as I build this out.

This first PR will aim to get us a working hello-triangle example, follow up PRs will build out more features. I'm trying to keep PRs as small as reasonable due to the hard lesseons we've learned in the past.

Testing

Doesn't work... yet :)

@cwfitzgerald cwfitzgerald force-pushed the dx11-iter-1 branch 3 times, most recently from 2e8d332 to 376afd5 Compare January 30, 2022 23:50
@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 30, 2022 23:50
@cwfitzgerald cwfitzgerald marked this pull request as draft January 30, 2022 23:50
@cwfitzgerald cwfitzgerald force-pushed the dx11-iter-1 branch 3 times, most recently from 6c40f78 to 9b43006 Compare March 5, 2022 17:29
@cwfitzgerald
Copy link
Member Author

Alright, this is ready for review, though dependent on gfx-rs/d3d12-rs#37.

This factors out a lot of the DXGI code into common code, as well as implementing DX11 adapter enumeration. The DX11 backend is behind an environment flag so that it will not show up unless you externally as for it.

The commits are self contained, but contain a dependency override on a fork, so it's up to you if to squash.

@cwfitzgerald cwfitzgerald requested a review from kvark March 5, 2022 17:30
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
It looks mergable, I left a few notes in case you are going to do another iteration.

wgpu-hal/Cargo.toml Outdated Show resolved Hide resolved
wgpu-hal/src/auxil/dxgi/conv.rs Show resolved Hide resolved
wgpu-hal/src/dx11/adapter.rs Show resolved Hide resolved
wgpu-hal/src/dx11/adapter.rs Show resolved Hide resolved
wgpu-hal/src/dx11/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/dx11/adapter.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald marked this pull request as ready for review March 12, 2022 16:53
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) March 12, 2022 16:53
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) March 12, 2022 17:01
@cwfitzgerald cwfitzgerald merged commit 73f4235 into gfx-rs:master Mar 12, 2022
@cwfitzgerald cwfitzgerald deleted the dx11-iter-1 branch March 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants