Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MULTISAMPLED_SHADING downlevel flag #2425

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Add MULTISAMPLED_SHADING downlevel flag #2425

merged 3 commits into from
Jan 28, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jan 27, 2022

Connections
About #2419

@jinleili jinleili changed the title Add MULTISAMPLED_SHADING downlevel flag (#2419) Add MULTISAMPLED_SHADING downlevel flag Jan 27, 2022
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise LGTM

wgpu-hal/src/vulkan/adapter.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed one thing

wgpu-hal/src/vulkan/adapter.rs Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit 9cff141 into gfx-rs:master Jan 28, 2022
cwfitzgerald pushed a commit that referenced this pull request Oct 25, 2023
* [wgsl-in] Fail on repeated attributes

Fixes #2425.

* [wgsl-in] Use ParsedAttribute to keep track of parsed attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants