Intel MSAA Resolve + SRGB

[cwfitzgerald]

Description

On intel/linux systems, there is a long standing issue with doing MSAA resolve at the same time as SRGB resolve will cause MSAA not to work and the clear color to not be properly converted into SRGB.

Platform

Linux + Intel GPU

What we do

• Verify this doesn't affect windows
• We need to warn when doing MSAA and SRGB on an intel chip on affected platforms.

[kvark]

gfx-rs has some internal logic to work around bugs, so in general we should first consider putting a workaround there. Perhaps what we should do for this issue is change image_format_properties implementation on Vulkan to report the maximum MSAA count of 1 only for SRGB formats only on the affected platforms?

Edit: we'd modify the sample_count_mask based on the target OS and some HW info like one defined here.

In wgpu, we may still need something - like a proper check for the sample count mask (if we don't have one), but at least it would be backend-agnostic at this level.

[cwfitzgerald]

I think we've fixed this.

[mockersf]

this seems to still happen in Bevy with wgpu 0.16