Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip the Y axis of the rendering coordinate system #519

Closed
kvark opened this issue Mar 15, 2020 · 1 comment
Closed

Flip the Y axis of the rendering coordinate system #519

kvark opened this issue Mar 15, 2020 · 1 comment
Labels
type: bug Something isn't working
Milestone
Version 0.5

Comments

@kvark
Copy link
Member

kvark commented Mar 15, 2020

We need to follow D3D convention here, according to:
@kvark kvark added the type: bug Something isn't working label Mar 15, 2020
@kvark kvark added this to the Version 0.5 milestone Mar 15, 2020
@grovesNL grovesNL mentioned this issue Mar 15, 2020
Merged
@kvark kvark mentioned this issue Mar 21, 2020
Merged
4 tasks
bors bot added a commit to gfx-rs/gfx that referenced this issue Mar 22, 2020
@bors @kvark
Merge #3170
29b7649 
3170: Support for NDC_Y_UP feature r=msiglreith a=kvark

Paves the way to gfx-rs/wgpu#519
PR checklist:
- [x] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code

If I undetstand correctly, the only thing missing here is a proper check for supported device extensions in Vulkan backend.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit to gfx-rs/gfx that referenced this issue Mar 22, 2020
@bors @kvark
Merge #3170
b945df3 
3170: Support for NDC_Y_UP feature r=msiglreith a=kvark

Paves the way to gfx-rs/wgpu#519
PR checklist:
- [x] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code

If I undetstand correctly, the only thing missing here is a proper check for supported device extensions in Vulkan backend.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit to gfx-rs/gfx that referenced this issue Mar 22, 2020
@bors @kvark
Merge #3170
553c8c4 
3170: Support for NDC_Y_UP feature r=msiglreith a=kvark

Paves the way to gfx-rs/wgpu#519
PR checklist:
- [x] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code

If I undetstand correctly, the only thing missing here is a proper check for supported device extensions in Vulkan backend.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark
Copy link
Member Author

kvark commented Mar 27, 2020

Fixed by #537

@kvark kvark closed this as completed Mar 27, 2020
@parasyte parasyte mentioned this issue Apr 13, 2020
Merged
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@crispweed
[rs] Removed erroneous zero size check related conditional in water e…
25aab2d 
…xample resize() (gfx-rs#534)

* The conditional at the start of resize() already tests for and exits on the zero width and height condition.
The conditional removed here was then getting run on every other call to resize(), which doesn't seem logical, doesn't correspond to the comment, and seemed to be causing at least one issue with rendered viewport going black during resize.

Fixes gfx-rs#532
(probably) Fixes gfx-rs#519

* Defensive coding to prevent various issues when window size goes to zero, e.g. NaN being passed in cgmath::perspective() aspect ratio parameter.

Fixes gfx-rs#531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
Version 0.5
Development

No branches or pull requests
1 participant
@kvark