Make wgpu_render_pass_set_bind_group clamp the number of dynamic offs…

…ets within limits.

CHANGELOG.md

@@ -174,6 +174,7 @@ Passing an owned value `window` to `Surface` will return a `Surface<'static>`. S
 #### General
 
 - `BufferMappedRange` trait is now `WasmNotSendSync`, i.e. it is `Send`/`Sync` if not on wasm or `fragile-send-sync-non-atomic-wasm` is enabled. By @wumpf in [#4818](https://github.com/gfx-rs/wgpu/pull/4818)
+- `wgpu_render_pass_set_bind_group` and `wgpu_compute_pass_set_bind_group` clamp the number of dynamic offsets to fit within limits. By @bradwerth in [#4918](https://github.com/gfx-rs/wgpu/pull/4918)
 
 #### Vulkan
 

wgpu-core/src/command/compute.rs

@@ -919,9 +919,17 @@ pub mod compute_ffi {
             return;
         }
 
+        // Clamp the number of dynamic offsets to the maximum value that the
+        // SetBindGroup structure supports.
+        let num_dynamic_offsets = if offset_length as u64 > std::u8::MAX.into() {
+            std::u8::MAX
+        } else {
+            offset_length as u8
+        };
+
         pass.base.commands.push(ComputeCommand::SetBindGroup {
             index,
-            num_dynamic_offsets: offset_length.try_into().unwrap(),
+            num_dynamic_offsets,
             bind_group_id,
         });
     }

wgpu-core/src/command/render.rs

@@ -2450,9 +2450,17 @@ pub mod render_ffi {
             return;
         }
 
+        // Clamp the number of dynamic offsets to the maximum value that the
+        // SetBindGroup structure supports.
+        let num_dynamic_offsets = if offset_length as u64 > std::u8::MAX.into() {
+            std::u8::MAX
+        } else {
+            offset_length as u8
+        };
+
         pass.base.commands.push(RenderCommand::SetBindGroup {
             index,
-            num_dynamic_offsets: offset_length.try_into().unwrap(),
+            num_dynamic_offsets,
             bind_group_id,
         });
     }