Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Add aribitrary texture size handling to the capture example #348

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Add aribitrary texture size handling to the capture example #348

merged 1 commit into from
Jun 6, 2020

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Jun 4, 2020

  • User can specify width + height via arguments.
  • Defaults to (100, 200) when no arguments. Odd values chosen to make it more likely to pick up issues when testing.
  • Converts from bgra as I believe that is the most commonly supported format for swapchains?

kvark
kvark suggested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a clever idea to demonstrate handling of the bytes_per_row in this example.
Just have a few concerns before we land

examples/capture/main.rs Outdated Show resolved Hide resolved
examples/capture/main.rs Outdated Show resolved Hide resolved
examples/capture/main.rs Outdated Show resolved Hide resolved
examples/capture/main.rs Outdated Show resolved Hide resolved
examples/capture/main.rs Outdated Show resolved Hide resolved
@rukai rukai force-pushed the extend_capture_example branch from e4478e5 to 51ce054 Compare June 5, 2020 11:34
@rukai
Copy link
Contributor Author

rukai commented Jun 5, 2020

Thanks for feedback, should be all addressed now.

kvark
kvark suggested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think it's all set, and looks beautiful. Just one last thing to fix, and we are good.

examples/capture/main.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald self-requested a review June 5, 2020 14:16
cwfitzgerald
cwfitzgerald suggested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a couple of comments focused on readability to beginners.

examples/capture/main.rs Outdated Show resolved Hide resolved
examples/capture/main.rs Outdated Show resolved Hide resolved
examples/capture/main.rs Outdated Show resolved Hide resolved
@rukai rukai force-pushed the extend_capture_example branch from 51ce054 to a8c3068 Compare June 5, 2020 14:25
kvark
kvark reviewed Jun 5, 2020
View reviewed changes
examples/capture/main.rs Outdated Show resolved Hide resolved
@rukai rukai force-pushed the extend_capture_example branch 2 times, most recently from ea43d93 to 309ee30 Compare June 5, 2020 14:51
@rukai rukai force-pushed the extend_capture_example branch from 309ee30 to f6123e4 Compare June 6, 2020 04:56
cwfitzgerald
cwfitzgerald approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r=me r=kvark

@bors
Copy link
Contributor

bors bot commented Jun 6, 2020

Build succeeded:

@bors bors bot merged commit d06470e into gfx-rs:master Jun 6, 2020
kejor pushed a commit to kejor/wgpu-rs that referenced this pull request Nov 28, 2020
@terrence2 @kvark
Support Limits::max_bind_groups (gfx-rs#348)
78fbbba 
* Pass max_bind_count down into Binder.
* Use the existing hub.
* Remove accidental newline.
kejor pushed a commit to kejor/wgpu-rs that referenced this pull request Nov 28, 2020
@bors @kvark
Merge gfx-rs#352
50acc29 
352: Fix compute pass resource binding r=kvark a=kvark

Follow-up to gfx-rs#348 
cc @grenlight @terrence2 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @kvark @cwfitzgerald