-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for emscripten build #171
Conversation
@kvark can we fork webgpu-headers under gfx-rs to apply emscripten workaound? webgpu-native/webgpu-headers#146 |
We can, yeah, although it would be good to not do that:) |
Yes I tried, and this solution also works. But, I really worried that 65536 is too small for index/epoch? Or you think its ok? -- Another solution that I have in mind is to doing copy of headers and patch them when make: make lib-native-emscripten It will cp webgpu.h into emscripten/webgpu.h and patch it. What do you think is it acceptable? |
I think 32-bit indices are acceptable, especially with gfx-rs/wgpu#2462 merged. |
f7d731e
to
f078cc3
Compare
ready |
#version = "0.11" | ||
features = ["raw-window-handle", "id32"] | ||
|
||
[target.'cfg(target_os = "emscripten")'.dependencies.hal] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be needed - wgpu-core already depends on wgpu-hal with emscripten feature enabled
rev = "8b66507" | ||
# path = "../wgpu/wgpu-core" | ||
#version = "0.11" | ||
features = ["raw-window-handle", "id32"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if wgpu-core could detect the need for id32
automatically? Basically, to make it a platform detection instead of an explicit feature.
Closing this as on web/wasm Emscripten provides it's own Only thing |
Added support for emscripten build. It's draft because, I am waiting for completion of other PRs (wgpu, headers).
Also, how I can edit wiki to add emscripten instructions?
--