Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split UnaryOperator::Not into UnaryOperator::LogicalNot & UnaryOperator::BitwiseNot #2554

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 12, 2023

since it should not be valid to use the logical and bitwise not operators interchangeably.

Also, don't allow UnaryOperator::Negate to operate on booleans (no frontend/backend supports this).

…perator::BitwiseNot`

since it should not be valid to use the logical and bitwise not operators interchangeably

also, don't allow `UnaryOperator::Negate` to operate on booleans (no frontend/backend supports this)
@teoxoy teoxoy requested a review from a team as a code owner October 12, 2023 12:00
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/valid/expression.rs Show resolved Hide resolved
@jimblandy jimblandy merged commit 04562de into gfx-rs:master Oct 16, 2023
5 checks passed
@teoxoy teoxoy deleted the split-not branch October 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants