Require that Function and Private variables be CONSTRUCTIBLE.
#2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
kind: bug
Change the validator to enforce WGSL's requirement that all variables in the `function` and `private` address spaces must have constructible types. Mark the `RayQuery` type as `CONSTRUCTIBLE`, since it is intended to be used for local variables. Add a regression test.
jimblandy
force-pushed
the
function-vars-constructible
branch
from
d038488
to
0af5179
Compare
jimblandy
changed the title
Function variables have CONSTRUCTIBLE types.Function and Private variables be CONSTRUCTIBLE.
teoxoy
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the validator to enforce WGSL's requirement that all variables
in the
functionandprivateaddress spaces must have constructibletypes.
Mark the
RayQuerytype asCONSTRUCTIBLE, since it is intended tobe used for local variables.
Add a regression test.