Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IsFinite & IsNormal completely #2532

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 3, 2023

None of the frontends support those.
SPIR-V's OpIsFinite & OpIsNormal require the Kernel capability which is only available in OpenCL.

References
The OpenCL™ SPIR-V Environment Specification
Appendix A: Vulkan Environment for SPIR-V

Backends also have very limited support, only MSL supports both, HLSL supports IsFinite, the others don't support any.

@teoxoy teoxoy requested a review from jimblandy October 13, 2023 16:35
@jimblandy jimblandy merged commit d71f254 into gfx-rs:master Oct 16, 2023
5 checks passed
@teoxoy teoxoy deleted the rem-IsFinite-IsNormal branch October 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants