Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgsl-in] Handle modf and frexp #2452

Closed
wants to merge 1 commit into from

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Aug 22, 2023

Another approach than what is done here would be to use TypeInner::Struct to reuse struct handling logic. There are some changes necessary there to handle naming correctly, and e.g. avoid writing out the struct in wgsl-out (which already has the struct defined).

Let med know if you want that done instead (and if so, how to proceed there - perhaps adding something like a enum StructType { UserDefined, ModfResult, FrexpResult } (and perhaps AtomicCompareExchangeWeaResult?) to TypeInner::Struct)!

@fornwall fornwall force-pushed the modf-and-frexp branch 3 times, most recently from 40393f1 to 809e378 Compare August 22, 2023 07:57
@fornwall
Copy link
Contributor Author

fornwall commented Aug 23, 2023

Replaced by a TypeInner::Struct using variant (#2453).

@fornwall fornwall closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change frexp and modf to work with structures Figure out modf story
1 participant