Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit non referenced expressions #2378

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jun 12, 2023

No description provided.

@teoxoy
Copy link
Member Author

teoxoy commented Jun 12, 2023

Seems HLSL validation is failing on gfx-rs/wgpu#4555 which should be fixed by #2367.

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

arg,
arg1,
arg2,
arg3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I think I've seen several of these fixed recently. I did a quick look and I think this must the last - the other places that use Math { .. } are sites that can't produce results at all without the arguments, so .. is probably okay there.

@@ -868,7 +873,7 @@ impl FunctionInfo {
S::Loop {
ref body,
ref continuing,
break_if: _,
break_if,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants