Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spv-out: implement OpArrayLength on array buffer bindings #2372

Closed
wants to merge 2 commits into from
Closed

spv-out: implement OpArrayLength on array buffer bindings #2372

wants to merge 2 commits into from

Conversation

kvark
Copy link
Member

@kvark kvark commented Jun 6, 2023

@kvark kvark requested a review from jimblandy June 6, 2023 07:43
@jimblandy
Copy link
Member

Rebased to get rid of changes to irrelevant snapshot files

jimblandy
jimblandy reviewed Jun 10, 2023
View reviewed changes
src/back/spv/index.rs Outdated Show resolved Hide resolved
src/back/spv/mod.rs Outdated Show resolved Hide resolved
jimblandy
jimblandy requested changes Jun 11, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the back/spv changes can be simplified; see the earlier comments.

@kvark
Copy link
Member Author

kvark commented Jun 20, 2023

@jimblandy please take a look at the comments, PR is rebased

jimblandy
jimblandy reviewed Jun 22, 2023
View reviewed changes
src/back/spv/index.rs Outdated Show resolved Hide resolved
@kvark
Copy link
Member Author

kvark commented Jun 23, 2023

@jimblandy ready for round 3
Amazing review, as always, and thanks for the insights!

@JMS55
Copy link
Contributor

JMS55 commented Aug 4, 2023

Thanks so much for the work on this! Any chance it can be rebased to naga main?

@JMS55 JMS55 mentioned this pull request Oct 3, 2023
Closed
@cwfitzgerald
Copy link
Member

Hello, thank you for your PR against Naga!

As part of gfx-rs/wgpu#4231, we have moved development of Naga into the wgpu repository in the Naga subfolder. We have transferred all issues, but we are unable to automatically transfer PRs.

As such, please recreate your PR against the wgpu repository. We apologize for the inconvenience this causes, but will make contributing to both projects more streamlined going forward.

We are leaving PRs open, but once they are transferred, please close the original Naga PR.

@kvark kvark mentioned this pull request Mar 23, 2024
Merged
6 tasks
@kvark
Copy link
Member Author

kvark commented Mar 23, 2024

Ported as gfx-rs/wgpu#5428

@kvark kvark closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spv-out] Cannot use arrayLength() on a runtime-sized array contained within a binding_array
4 participants
@kvark @jimblandy @JMS55 @cwfitzgerald