Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glsl-in] Switch implicit type conversion #2273

Merged
merged 1 commit into from
Mar 14, 2023
Merged

[glsl-in] Switch implicit type conversion #2273

merged 1 commit into from
Mar 14, 2023

Conversation

evahop
Copy link
Contributor

@evahop evahop commented Mar 10, 2023

GLSL allows for implicitly converting int -> uint in switch cases.

JCapucho
JCapucho approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work :)

@teoxoy teoxoy merged commit 7f829c6 into gfx-rs:master Mar 14, 2023
kvark pushed a commit to kvark/naga that referenced this pull request Mar 18, 2023
@evahop @kvark
[glsl-in] Switch implicit type conversion (gfx-rs#2273)
ac382b8
@evahop evahop deleted the glsl-switch branch September 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCapucho JCapucho JCapucho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evahop @JCapucho @teoxoy